HomePhabricator

Fix a compatibility issue with `ArcanistUnsafeDynamicStringXHPASTLinterRule`

Description

Fix a compatibility issue with ArcanistUnsafeDynamicStringXHPASTLinterRule

Summary: A user reported to me that arc lint was failing with an error message along the lines of "argument 1 passed to idx must be of type array, bool given". I suspect that the user is running an older version of PHP, which means that array_combine(array(), array()) is returning false instead of the expected array(). Instead, avoid calling array_combine on an empty array.

Test Plan: I don't have PHP 5.3 easily accessible to test this.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D14567