Paths

Table of Contentst

Fix parsing of `ruby` version for `ArcanistRubyLinter`
ClosedPublic
Actions

Authored by joshuaspence on Nov 19 2015, 9:36 PM.

Tags

None

Referenced Files

	F13238276: D14525.id35136.diff
	Tue, May 21, 6:30 PM

	F13234799: D14525.diff
	Tue, May 21, 3:45 AM

	F13226650: D14525.id.diff
	Sun, May 19, 10:13 PM

	F13212763: D14525.diff
	Fri, May 17, 7:02 AM

	F13200857: D14525.diff
	Tue, May 14, 4:29 AM

	F13197493: D14525.diff
	Mon, May 13, 12:13 AM

	F13179955: D14525.diff
	Wed, May 8, 9:33 PM

	Unknown Object (File)
	Sat, May 4, 7:27 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC187e10e7810b: Fix parsing of `ruby` version for `ArcanistRubyLinter`

Summary

This fails to extract the version correctly locally.

> ruby --version
ruby 1.8.7 (2014-01-28 patchlevel 376) [x86_64-linux]

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35136.Nov 19 2015, 9:36 PM

joshuaspence retitled this revision from to Fix parsing of `ruby` version for `ArcanistRubyLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2015, 9:36 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 19 2015, 9:51 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 19 2015, 9:51 PM

Closed by commit rARC187e10e7810b: Fix parsing of `ruby` version for `ArcanistRubyLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 19 2015, 11:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistRubyLinter.php

2 lines

Diff 35139

View Options

src/lint/linter/ArcanistRubyLinter.php

Fix parsing of `ruby` version for `ArcanistRubyLinter`ClosedPublicActions