Paths

Table of Contentst

Differential D14525

Fix parsing of `ruby` version for `ArcanistRubyLinter`
ClosedPublic
Actions

Authored by joshuaspence on Nov 19 2015, 9:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 4:16 AM

	Unknown Object (File)
	Fri, Dec 13, 6:23 PM

	Unknown Object (File)
	Wed, Dec 11, 7:49 PM

	Unknown Object (File)
	Tue, Dec 10, 12:07 AM

	Unknown Object (File)
	Fri, Dec 6, 6:44 AM

	Unknown Object (File)
	Wed, Dec 4, 2:51 AM

	Unknown Object (File)
	Tue, Nov 26, 4:31 AM

	Unknown Object (File)
	Nov 22 2024, 5:24 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC187e10e7810b: Fix parsing of `ruby` version for `ArcanistRubyLinter`

Summary

This fails to extract the version correctly locally.

> ruby --version
ruby 1.8.7 (2014-01-28 patchlevel 376) [x86_64-linux]

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8946
Build 10500: Run Core Tests
Build 10499: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	242 ms	ArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
	332 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	14 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistArrayIndexSpacingXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 188 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35136.Nov 19 2015, 9:36 PM

joshuaspence retitled this revision from to Fix parsing of `ruby` version for `ArcanistRubyLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2015, 9:36 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 19 2015, 9:51 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 19 2015, 9:51 PM

Closed by commit rARC187e10e7810b: Fix parsing of `ruby` version for `ArcanistRubyLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 19 2015, 11:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistRubyLinter.php

2 lines

Diff 35136

src/lint/linter/ArcanistRubyLinter.php

Loading...