Paths

Table of Contentst

Differential D14499

Fix brace formatting linter rule after XHPAST changes
ClosedPublic
Actions

Authored by joshuaspence on Nov 17 2015, 10:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 7:48 PM

	Unknown Object (File)
	Wed, Dec 18, 3:14 PM

	Unknown Object (File)
	Fri, Dec 13, 6:22 PM

	Unknown Object (File)
	Thu, Dec 12, 4:39 PM

	Unknown Object (File)
	Thu, Nov 28, 6:13 PM

	Unknown Object (File)
	Wed, Nov 27, 11:19 PM

	Unknown Object (File)
	Wed, Nov 27, 3:21 AM

	Unknown Object (File)
	Mon, Nov 25, 2:44 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCe3e232530c6e: Fix brace formatting linter rule after XHPAST changes

Summary

Adjusts ArcanistBraceFormattingXHPASTLinterRule after changes to the way in which XHPAST parses namespaces. Depends on D14498.

Test Plan

Unit tests are now passing.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8884
Build 10398: Run Core Tests
Build 10397: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	161 ms	ArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
	317 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	9 ms	ArcanistRubyLinterTestCase::Unknown Unit Message ("")
	1 ms	ArcanistBaseCommitParserTestCase::Unknown Unit Message ("")
	0 ms	ArcanistBaseCommitParserTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 112 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35074.Nov 17 2015, 10:38 AM

joshuaspence retitled this revision from to Fix brace formatting linter rule after XHPAST changes.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D14498: Improve parsing of namespaces.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 17 2015, 10:38 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 17 2015, 3:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 17 2015, 3:18 PM

Closed by commit rARCe3e232530c6e: Fix brace formatting linter rule after XHPAST changes (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 17 2015, 8:20 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in rARCa4dba24c468c: Prevent double rendering of unit test results.Nov 17 2015, 8:37 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistBraceFormattingXHPASTLinterRule.php

15 lines

Diff 35074

src/lint/linter/xhpast/rules/ArcanistBraceFormattingXHPASTLinterRule.php

Loading...