Fix brace formatting linter rule after XHPAST changes
ClosedPublic
Actions

Authored by joshuaspence on Nov 17 2015, 10:38 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCe3e232530c6e: Fix brace formatting linter rule after XHPAST changes

Summary

Adjusts ArcanistBraceFormattingXHPASTLinterRule after changes to the way in which XHPAST parses namespaces. Depends on D14498.

Test Plan

Unit tests are now passing.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35074.Nov 17 2015, 10:38 AM

joshuaspence retitled this revision from to Fix brace formatting linter rule after XHPAST changes.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D14498: Improve parsing of namespaces.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 17 2015, 10:38 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 17 2015, 3:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 17 2015, 3:18 PM

Closed by commit rARCe3e232530c6e: Fix brace formatting linter rule after XHPAST changes (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 17 2015, 8:20 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in rARCa4dba24c468c: Prevent double rendering of unit test results.Nov 17 2015, 8:37 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistBraceFormattingXHPASTLinterRule.php

15 lines

Diff 35085

View Options

src/lint/linter/xhpast/rules/ArcanistBraceFormattingXHPASTLinterRule.php

Fix brace formatting linter rule after XHPAST changesClosedPublicActions