Page MenuHomePhabricator

Fix file PHID extraction in Owners and Differential
ClosedPublic

Authored by epriestley on Nov 16 2015, 6:02 PM.
Tags
None
Referenced Files
F13213827: D14493.diff
Fri, May 17, 8:06 AM
F13182293: D14493.diff
Thu, May 9, 10:38 PM
Unknown Object (File)
Tue, May 7, 8:28 AM
Unknown Object (File)
Fri, May 3, 8:19 AM
Unknown Object (File)
Fri, May 3, 7:50 AM
Unknown Object (File)
Thu, Apr 25, 2:16 AM
Unknown Object (File)
Apr 18 2024, 12:43 AM
Unknown Object (File)
Apr 9 2024, 12:28 PM
Subscribers

Details

Summary

Ref T9787. To fix this, I want to change how file PHIDs are extracted slightly: specifically, I'm going to extract them later in the editing process.

Before doing this, clean up a couple of bad implementations:

  • Owners extracts its description as a file PHID. This is an error.
    • Extract the description as a remarkup block instead.
    • Add an edge table so stuff like file attachment works properly.
  • Differential has a no-op extract method. This is presumably just a copy/paste issue from long ago.
Test Plan
  • Edited a revision in Differential.
  • Dropped a file into the description of an Owners package.
    • Before change: this did not attach the file.
    • After change: the file now attaches properly and shows up as "Attached" in the file details.

Diff Detail

Repository
rP Phabricator
Branch
eengine14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8873
Build 10380: Run Core Tests
Build 10379: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix file PHID extraction in Owners and Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Nov 16 2015, 7:20 PM
This revision was automatically updated to reflect the committed changes.