Page MenuHomePhabricator
Differential D14461

Allow device bindings to be destroyed
ClosedPublic
Actions

Authored by joshuaspence on Nov 11 2015, 1:17 AM.
Tags
None
Referenced Files
F15507605: D14461.id35052.diff
Tue, Apr 15, 9:39 PM
F15471774: D14461.id35052.diff
Sat, Apr 5, 8:03 AM
F15458302: D14461.id.diff
Sun, Mar 30, 10:51 PM
F15457189: D14461.diff
Sun, Mar 30, 2:49 PM
F15456284: D14461.id34976.diff
Sun, Mar 30, 8:25 AM
F15454783: D14461.diff
Sat, Mar 29, 8:24 PM
F15440919: D14461.id.diff
Wed, Mar 26, 3:27 PM
F15386625: D14461.diff
Mar 15 2025, 12:58 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9762: Removing devices from Almanac services
Commits
Restricted Diffusion Commit
rP67b6c532bc54: Allow device bindings to be destroyed
Summary

Ref T9762. Currently it is not possible to destroy an Alamanac device because any associate bindings cannot be destroyed.

Test Plan

Destroyed an Almanac device.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8786
Build 10235: Run Core Tests
Build 10234: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 34976.Nov 11 2015, 1:17 AM
joshuaspence retitled this revision from to Allow device bindings to be destroyed.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 11 2015, 1:17 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this object.Nov 14 2015, 10:46 AM
joshuaspence edited edge metadata.
joshuaspence added a task: T9762: Removing devices from Almanac services.
joshuaspence updated this object.
epriestley accepted this revision.Nov 15 2015, 4:50 PM
epriestley edited edge metadata.

This should also destroy associated AlmanacProperty objects, although leaving them around isn't a huge deal.

Possibly DestructionEngine should be more flexible and use some module to automatically destroy AlmanacProperty objects associated with any object which implements AlmanacPropertyInterface.

This revision is now accepted and ready to land.Nov 15 2015, 4:50 PM
Closed by commit rP67b6c532bc54: Allow device bindings to be destroyed (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 15 2015, 8:15 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D14490: Permanently destroy Almanac properties with the destruction engine.Nov 15 2015, 8:36 PM
joshuaspence mentioned this in rP1a84a2fe4bc4: Permanently destroy Almanac properties with the destruction engine.Nov 15 2015, 8:58 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
1 line--
applications/
almanac/
storage/
13 lines2%
Loading...

Diff 34976

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/storage/AlmanacBinding.php

Loading...
Phabricator · Built by Phacility