Page MenuHomePhabricator

Allow device bindings to be destroyed
ClosedPublic

Authored by joshuaspence on Nov 11 2015, 1:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 12:41 AM
Unknown Object (File)
Sat, Nov 30, 12:41 AM
Unknown Object (File)
Sat, Nov 30, 12:41 AM
Unknown Object (File)
Sat, Nov 30, 12:24 AM
Unknown Object (File)
Wed, Nov 27, 7:20 PM
Unknown Object (File)
Sat, Nov 23, 6:59 AM
Unknown Object (File)
Nov 19 2024, 7:25 PM
Unknown Object (File)
Nov 15 2024, 10:52 PM
Subscribers

Details

Summary

Ref T9762. Currently it is not possible to destroy an Alamanac device because any associate bindings cannot be destroyed.

Test Plan

Destroyed an Almanac device.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8786
Build 10235: Run Core Tests
Build 10234: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Allow device bindings to be destroyed.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This should also destroy associated AlmanacProperty objects, although leaving them around isn't a huge deal.

Possibly DestructionEngine should be more flexible and use some module to automatically destroy AlmanacProperty objects associated with any object which implements AlmanacPropertyInterface.

This revision is now accepted and ready to land.Nov 15 2015, 4:50 PM
This revision was automatically updated to reflect the committed changes.