Paths

Table of Contentst

Differential D14071

Various translation improvements
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2015, 6:12 AM.

Tags

None

Referenced Files

	F14438160: D14071.diff
	Thu, Dec 26, 2:18 AM

	Unknown Object (File)
	Fri, Dec 13, 1:52 AM

	Unknown Object (File)
	Thu, Dec 12, 9:33 AM

	Unknown Object (File)
	Sat, Dec 7, 11:00 PM

	Unknown Object (File)
	Thu, Dec 5, 7:31 PM

	Unknown Object (File)
	Tue, Dec 3, 12:30 AM

	Unknown Object (File)
	Nov 15 2024, 12:48 PM

	Unknown Object (File)
	Nov 11 2024, 3:50 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU69b641e4c6f2: Various translation improvements

Summary

Depends on D14070.

Test Plan

Eyeball it.

Diff Detail

Repository

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/utils/utils.php:1187	XHP45	PHP Compatibility
Error	src/utils/utils.php:1187	XHP45	PHP Compatibility

Unit

Tests Passed

Build Status

Buildable 8527
Build 9839: Run Core Tests
Build 9838: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 34011.Sep 6 2015, 6:12 AM

joshuaspence retitled this revision from to Various translation improvements.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D14070: Add a `phutil_count` function.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2015, 6:12 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Sep 6 2015, 3:04 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/moduleutils/PhutilLibraryMapBuilder.php
471	Does `phutil_count()` actually exist? I can't find it defined anywhere. Maybe I'm reviewing these out of order... Probably should be `file(s)`.
src/utils/viewutils.php
7–9 ↗	(On Diff #34011)	Maybe just leave these for now -- I think there's some intentional code which tries to localize them. But we're moving away from this in general, so probably fine either way.

This revision is now accepted and ready to land.Sep 6 2015, 3:04 PM

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Leave strings in phutil_date_format untouched

Minor fixes

Closed by commit rPHU69b641e4c6f2: Various translation improvements (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 2 2015, 10:23 AM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D14378: Add some missing translations.Nov 2 2015, 10:28 AM

joshuaspence mentioned this in rPHU2826ef3c683b: Add some missing translations.Nov 2 2015, 7:54 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

daemon/

PhutilDaemon.php

6 lines

1%

Loading...

filesystem/

34 lines

38%

Loading...

future/

exec/

CommandException.php

2 lines

5%

Loading...

2 lines

66%

Loading...

oauth/

PhutilOAuth1Future.php

2 lines

58%

Loading...

moduleutils/

PhutilLibraryMapBuilder.php

6 lines

54%

Loading...

parser/

__tests__/

PhutilJSONTestCase.php

2 lines

100%

Loading...

xhpast/

__tests__/

PHPASTParserTestCase.php

5 lines

63%

Loading...

serviceprofiler/

PhutilServiceProfiler.php

8 lines

13%

Loading...

utils/

6 lines

71%

Loading...

Diff 34717

src/daemon/PhutilDaemon.php

Loading...

src/filesystem/Filesystem.php

Loading...

src/future/exec/CommandException.php

Loading...

src/future/exec/ExecFuture.php

Loading...

src/future/oauth/PhutilOAuth1Future.php

Loading...

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...

src/parser/tests/PhutilJSONTestCase.php

Loading...

src/parser/xhpast/tests/PHPASTParserTestCase.php

Loading...

src/serviceprofiler/PhutilServiceProfiler.php

Loading...

src/utils/utils.php

Loading...