Page MenuHomePhabricator

Add some missing translations
ClosedPublic

Authored by joshuaspence on Nov 2 2015, 10:28 AM.

Details

Summary

Add some missing translations from D14071.

Test Plan

I'm actually not sure where these are meant to go... we don't seem to store any translations in rPHU.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add some missing translations.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

These should go in libphutil/, we just haven't translated anything there yet. Just add a similar translation file, like the ones in Arcanist and Phabricator.

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
1435–1436 ↗(On Diff #34722)

Consider spelling out the singular cases, "Analyzing 1 file with 1 subprocess..." is still more stilted in English than, e.g., "Analyzing one file with a single subprocess..."

1445 ↗(On Diff #34722)

Missing closing parenthesis.

This revision is now accepted and ready to land.Nov 2 2015, 1:02 PM
joshuaspence marked 2 inline comments as done.
joshuaspence edited edge metadata.
  • Move to rPHU
  • Fix missing parentheses
This revision was automatically updated to reflect the committed changes.