Page MenuHomePhabricator
Differential D14367

Move "Next Step" to a custom field in Differential
ClosedPublic
Actions

Authored by epriestley on Oct 30 2015, 2:47 PM.
Tags
None
Referenced Files
F13281462: D14367.diff
Sun, Jun 2, 10:50 AM
F13249762: D14367.id34693.diff
Fri, May 24, 11:09 AM
F13249760: D14367.id34688.diff
Fri, May 24, 11:09 AM
F13249759: D14367.id.diff
Fri, May 24, 11:09 AM
F13249758: D14367.diff
Fri, May 24, 11:09 AM
F13225844: D14367.id34688.diff
Sun, May 19, 5:44 PM
F13208542: D14367.id34688.diff
Thu, May 16, 5:10 PM
F13193955: D14367.id.diff
Sun, May 12, 7:42 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9672: Make it possible to modify or disable differential's "next step" property
Commits
Restricted Diffusion Commit
rP2c3dbc48ee95: Move "Next Step" to a custom field in Differential
Summary

Fixes T9672. This was never turned into a custom field, for no particular reason. Convert it into one.

This is substantially similar to the existing "Apply Patch" field, which does the same thing (only shows a command).

We might rethink or remove this eventually (e.g., in a post-"Land Revision" world) but this makes it easier, at the very least.

Test Plan
  • Viewed a non-accepted revision (no hint).
  • Viewed an accepted revision from a raw diff source (no hint).
  • Viewed an accepted revision from Git (arc land hint).

Diff Detail

Repository
rP Phabricator
Branch
nextstep1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8495
Build 9790: Run Core Tests
Build 9789: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34688.Oct 30 2015, 2:47 PM
epriestley retitled this revision from to Move "Next Step" to a custom field in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9672: Make it possible to modify or disable differential's "next step" property.
chad accepted this revision.Oct 30 2015, 3:55 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2015, 3:55 PM
Closed by commit rP2c3dbc48ee95: Move "Next Step" to a custom field in Differential (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2015, 4:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
config/
2 lines
customfield/
65 lines
view/
30 lines

Diff 34688

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/customfield/DifferentialNextStepField.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionDetailView.php

Loading...
Phabricator · Built by Phacility