Page MenuHomePhabricator
Differential D14367

Move "Next Step" to a custom field in Differential
ClosedPublic
Actions

Authored by epriestley on Oct 30 2015, 2:47 PM.
Tags
None
Referenced Files
F13053118: D14367.diff
Fri, Apr 19, 11:00 AM
Unknown Object (File)
Fri, Apr 12, 7:07 AM
Unknown Object (File)
Thu, Mar 28, 2:05 PM
Unknown Object (File)
Thu, Mar 28, 1:52 AM
Unknown Object (File)
Mar 5 2024, 3:43 AM
Unknown Object (File)
Mar 5 2024, 3:43 AM
Unknown Object (File)
Mar 5 2024, 2:30 AM
Unknown Object (File)
Mar 5 2024, 2:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9672: Make it possible to modify or disable differential's "next step" property
Commits
Restricted Diffusion Commit
rP2c3dbc48ee95: Move "Next Step" to a custom field in Differential
Summary

Fixes T9672. This was never turned into a custom field, for no particular reason. Convert it into one.

This is substantially similar to the existing "Apply Patch" field, which does the same thing (only shows a command).

We might rethink or remove this eventually (e.g., in a post-"Land Revision" world) but this makes it easier, at the very least.

Test Plan
  • Viewed a non-accepted revision (no hint).
  • Viewed an accepted revision from a raw diff source (no hint).
  • Viewed an accepted revision from Git (arc land hint).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34688.Oct 30 2015, 2:47 PM
epriestley retitled this revision from to Move "Next Step" to a custom field in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9672: Make it possible to modify or disable differential's "next step" property.
chad accepted this revision.Oct 30 2015, 3:55 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2015, 3:55 PM
Closed by commit rP2c3dbc48ee95: Move "Next Step" to a custom field in Differential (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2015, 4:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
config/
2 lines
customfield/
65 lines
view/
30 lines

Diff 34693

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/customfield/DifferentialNextStepField.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionDetailView.php

Loading...
Phabricator · Built by Phacility