Page MenuHomePhabricator

Move "Next Step" to a custom field in Differential
ClosedPublic

Authored by epriestley on Oct 30 2015, 2:47 PM.
Tags
None
Referenced Files
F12833482: D14367.id.diff
Thu, Mar 28, 2:05 PM
F12814214: D14367.diff
Thu, Mar 28, 1:52 AM
Unknown Object (File)
Tue, Mar 5, 3:43 AM
Unknown Object (File)
Tue, Mar 5, 3:43 AM
Unknown Object (File)
Tue, Mar 5, 2:30 AM
Unknown Object (File)
Tue, Mar 5, 2:30 AM
Unknown Object (File)
Feb 21 2024, 6:32 PM
Unknown Object (File)
Feb 10 2024, 10:11 AM
Subscribers
None

Details

Summary

Fixes T9672. This was never turned into a custom field, for no particular reason. Convert it into one.

This is substantially similar to the existing "Apply Patch" field, which does the same thing (only shows a command).

We might rethink or remove this eventually (e.g., in a post-"Land Revision" world) but this makes it easier, at the very least.

Test Plan
  • Viewed a non-accepted revision (no hint).
  • Viewed an accepted revision from a raw diff source (no hint).
  • Viewed an accepted revision from Git (arc land hint).

Diff Detail

Repository
rP Phabricator
Branch
nextstep1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8495
Build 9790: Run Core Tests
Build 9789: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Move "Next Step" to a custom field in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2015, 3:55 PM
This revision was automatically updated to reflect the committed changes.