Herald support for changing task status
ClosedPublic
Actions

Authored by jasonfsmitty on Oct 28 2015, 6:36 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions

Commits

Restricted Diffusion Commit
rPa77bf877d4f1: Herald support for changing task status

Summary

Ref T7848. This patch is incomplete and has the following issues:

Multiple statuses can be entered on the edit rule page (only the first one is used).
Statuses are not rendered correctly when re-editing a rule.

Test Plan

Applied to our local phab instance and verified it works with our task workflow.

Diff Detail

Repository

rP Phabricator

Branch

herald-status

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8476
Build 9761: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	ManiphestTaskTestCase::Unknown Unit Message ("")
	0 ms	ManiphestTaskTestCase::Unknown Unit Message ("")
	139 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("")
	4 ms	PhabricatorConduitTestCase::Unknown Unit Message ("")
	0 ms	PhabricatorInfrastructureTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 7 Passed)

Event Timeline

jasonfsmitty updated this revision to Diff 34669.Oct 28 2015, 6:36 PM

jasonfsmitty retitled this revision from to T7848: herald support for changing task status.

jasonfsmitty updated this object.

jasonfsmitty edited the test plan for this revision. (Show Details)

jasonfsmitty added a subscriber: jsmith.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 28 2015, 6:36 PM

Herald added a subscriber: epriestley. · View Herald Transcript

jasonfsmitty added a task: T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.Oct 28 2015, 6:36 PM

jasonfsmitty mentioned this in T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.Oct 28 2015, 6:49 PM

revi added a subscriber: revi.Oct 29 2015, 11:54 AM

joshuaspence retitled this revision from T7848: herald support for changing task status to Herald support for changing task status.Nov 13 2015, 9:35 AM

joshuaspence updated this object.

joshuaspence edited edge metadata.

joshuaspence added a subscriber: joshuaspence.

Some minor inlines, I'll just clean these up in the pull.

src/applications/maniphest/herald/ManiphestTaskStatusHeraldAction.php
26	Prefer `head()` to `reset()` in this codebase.
28	This should be DO_STANDARD_EMPTY (empty rule), not DO_STANDARD_NO_EFFECT (valid rule with no effect considering current state).
54	Use ManiphestTaskStatus::getTaskStatusName() to render a name.
55	Debugging/testing code.