Differential D14682

Improve rendering of tokenizer tokens in Herald when editing rules
ClosedPublic
Actions

Authored by epriestley on Dec 5 2015, 7:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 4:06 PM

	Unknown Object (File)
	Thu, Dec 12, 8:28 AM

	Unknown Object (File)
	Wed, Dec 11, 11:58 PM

	Unknown Object (File)
	Sun, Dec 1, 10:08 AM

	Unknown Object (File)
	Sun, Dec 1, 7:33 AM

	Unknown Object (File)
	Sun, Dec 1, 7:33 AM

	Unknown Object (File)
	Sun, Dec 1, 7:33 AM

	Unknown Object (File)
	Sat, Nov 30, 1:50 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions

Commits

Restricted Diffusion Commit
rP82be07315cbf: Improve rendering of tokenizer tokens in Herald when editing rules

Summary

Fixes T7848. @jasonfsmitty discussed an issue in great detail there and in D14359, and I completely missed it. Specifically:

If you save a "Change status to: Open" rule in Maniphest, and then edit it again, the token shows "Unknown Object (???)" instead of the correct token.
That's because loadHandles() has no idea what to do with the value "open", since it's not a real PHID.

The way we render tokenizer tokens in Herald is quite hacky right now. Fortunately, I wrote a slightly better way for EditEngine yesterday or the day before. Use the slightly better way to fix the issue with D14359.

This could still be better than it is, but the badness is mostly hidden now and can be cleaned up later without impacting anything.

Test Plan

Edited a Herald rule with projects and status changes, saw proper tokens.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35510.Dec 5 2015, 7:12 PM

epriestley retitled this revision from to Improve rendering of tokenizer tokens in Herald when editing rules.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.

epriestley added a subscriber: jasonfsmitty.

chad accepted this revision.Dec 5 2015, 7:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 5 2015, 7:14 PM

epriestley mentioned this in D14683: Add a "Change priority to: ..." Herald action.Dec 5 2015, 7:17 PM

Closed by commit rP82be07315cbf: Improve rendering of tokenizer tokens in Herald when editing rules (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 7:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPf22dc9d47a5d: Add a "Change priority to: ..." Herald action.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

22 lines

src/

applications/

herald/

action/

HeraldAction.php

10 lines

value/

HeraldTokenizerFieldValue.php

20 lines

webroot/

rsrc/

js/

application/

herald/

HeraldRuleEditor.js

3 lines

Diff 35512

resources/celerity/map.php

Loading...

src/applications/herald/action/HeraldAction.php

Loading...

src/applications/herald/value/HeraldTokenizerFieldValue.php

Loading...

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

Loading...