Page MenuHomePhabricator
Differential D14308

In PHUIInfoView, only show list UI if more than 1 item
ClosedPublic
Actions

Authored by chad on Oct 19 2015, 11:24 PM.
Tags
None
Referenced Files
F13242415: D14308.diff
Thu, May 23, 2:45 AM
F13226797: D14308.id.diff
Sun, May 19, 11:29 PM
F13220669: D14308.diff
Sun, May 19, 1:51 AM
F13216014: D14308.id34537.diff
Fri, May 17, 9:51 PM
F13203474: D14308.diff
Tue, May 14, 11:47 PM
F13185313: D14308.diff
Sat, May 11, 2:47 AM
Unknown Object (File)
Tue, May 7, 5:14 AM
Unknown Object (File)
Sat, May 4, 8:32 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPbbbda23678dd: In PHUIInfoView, only show list UI if more than 1 item
Summary

We often just setError as an array even if it's only one error. This just makes the UI a little cleaner in these cases.

Test Plan

Remove all reviewers from a diff, see status error without list styling.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34537.Oct 19 2015, 11:24 PM
chad retitled this revision from to In PHUIInfoView, only show list UI if more than 1 item.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 19 2015, 11:24 PM
epriestley accepted this revision.Oct 20 2015, 2:12 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2015, 2:12 AM
Closed by commit rPbbbda23678dd: In PHUIInfoView, only show list UI if more than 1 item (authored by chad, committed by chad). · Explain WhyOct 20 2015, 3:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
form/
4 lines

Diff 34540

View Options

src/view/form/PHUIInfoView.php

Loading...
Phabricator · Built by Phacility