Page MenuHomePhabricator

In PHUIInfoView, only show list UI if more than 1 item
ClosedPublic

Authored by chad on Oct 19 2015, 11:24 PM.
Tags
None
Referenced Files
F12841620: D14308.diff
Thu, Mar 28, 9:20 PM
Unknown Object (File)
Feb 22 2024, 6:59 PM
Unknown Object (File)
Feb 22 2024, 6:59 PM
Unknown Object (File)
Feb 14 2024, 10:25 PM
Unknown Object (File)
Feb 14 2024, 4:22 PM
Unknown Object (File)
Feb 6 2024, 4:38 AM
Unknown Object (File)
Jan 14 2024, 7:41 PM
Unknown Object (File)
Jan 10 2024, 1:20 PM
Subscribers

Details

Summary

We often just setError as an array even if it's only one error. This just makes the UI a little cleaner in these cases.

Test Plan

Remove all reviewers from a diff, see status error without list styling.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to In PHUIInfoView, only show list UI if more than 1 item.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2015, 2:12 AM
This revision was automatically updated to reflect the committed changes.