Page MenuHomePhabricator
Differential D14308

In PHUIInfoView, only show list UI if more than 1 item
ClosedPublic
Actions

Authored by chad on Oct 19 2015, 11:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 4:59 AM
Unknown Object (File)
Sat, Feb 1, 2:05 AM
Unknown Object (File)
Tue, Jan 28, 4:45 PM
Unknown Object (File)
Sun, Jan 26, 3:39 PM
Unknown Object (File)
Dec 13 2024, 2:43 AM
Unknown Object (File)
Dec 11 2024, 1:37 AM
Unknown Object (File)
Dec 5 2024, 7:38 PM
Unknown Object (File)
Oct 24 2024, 6:20 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPbbbda23678dd: In PHUIInfoView, only show list UI if more than 1 item
Summary

We often just setError as an array even if it's only one error. This just makes the UI a little cleaner in these cases.

Test Plan

Remove all reviewers from a diff, see status error without list styling.

Diff Detail

Repository
rP Phabricator
Branch
errrorr
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8350
Build 9581: Run Core Tests
Build 9580: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34537.Oct 19 2015, 11:24 PM
chad retitled this revision from to In PHUIInfoView, only show list UI if more than 1 item.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 19 2015, 11:24 PM
epriestley accepted this revision.Oct 20 2015, 2:12 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2015, 2:12 AM
Closed by commit rPbbbda23678dd: In PHUIInfoView, only show list UI if more than 1 item (authored by chad, committed by chad). · Explain WhyOct 20 2015, 3:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
form/
4 lines

Diff 34537

View Options

src/view/form/PHUIInfoView.php

Loading...
Phabricator · Built by Phacility