Ref T9456. Some rough edges and we can't complete the build yet since I haven't written a webhook, but this mostly seems to be working.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T9456: Evaluate upstream support for third-party build systems
- Commits
- Restricted Diffusion Commit
rPf82db7524b32: Add a "Build with CircleCI" build step
- Ran this build on some stuff.
- Ran a normal HTTP step build to make sure I didn't break that.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- circle3
- Lint
Lint Passed Severity Location Code Message Advice src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php:282 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 8300 Build 9513: Run Core Tests Build 9512: arc lint + arc unit
Event Timeline
Comment Actions
- Avoid triggering CircleCI issue with questionable branch name.
- Support building commits.
| src/applications/harbormaster/step/HarbormasterCircleCIBuildStepImplementation.php | ||
|---|---|---|
| 140 |
| |
Comment Actions
- Remove KeyValuePair stuff which we don't need.
- Add Artifact stuff to generate a link to CircleCI.
Comment Actions
out of curiosity, are this diff and D14288 on hold indefinitely? we're hitting some growing pains and would love to have circle ci results in diffs, so debating if we should wait a month or just go ahead and roll our own hacky hooks
Comment Actions
We're waiting on CircleCI, you'd have to ask them if you want a timeline.
As soon as CircleCI builds tags, I'll point this at whatever the new API is and land it.