Page MenuHomePhabricator

Add a "Build with CircleCI" build step
ClosedPublic

Authored by epriestley on Oct 15 2015, 4:02 AM.
Tags
None
Referenced Files
F12829481: D14286.diff
Thu, Mar 28, 11:32 AM
F12812325: D14286.id37364.diff
Thu, Mar 28, 12:05 AM
Unknown Object (File)
Fri, Mar 22, 10:52 AM
Unknown Object (File)
Mon, Mar 18, 5:03 AM
Unknown Object (File)
Sat, Mar 16, 6:23 PM
Unknown Object (File)
Sat, Mar 16, 5:04 PM
Unknown Object (File)
Sat, Mar 16, 4:49 PM
Unknown Object (File)
Sat, Mar 16, 3:31 PM

Details

Summary

Ref T9456. Some rough edges and we can't complete the build yet since I haven't written a webhook, but this mostly seems to be working.

Test Plan
  • Ran this build on some stuff.
  • Ran a normal HTTP step build to make sure I didn't break that.

Screen Shot 2015-10-14 at 8.56.59 PM.png (1×2 px, 182 KB)

Screen Shot 2015-10-14 at 8.56.42 PM.png (1×2 px, 226 KB)

Screen Shot 2015-10-14 at 8.56.48 PM.png (1×2 px, 375 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a "Build with CircleCI" build step.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Avoid triggering CircleCI issue with questionable branch name.
  • Support building commits.
chad edited edge metadata.
chad added inline comments.
src/applications/harbormaster/step/HarbormasterCircleCIBuildStepImplementation.php
140

This revision is now accepted and ready to land.Oct 15 2015, 4:00 PM
epriestley edited edge metadata.
  • Remove KeyValuePair stuff which we don't need.
  • Add Artifact stuff to generate a link to CircleCI.
  • Rebase after possible CircleCI changes.

out of curiosity, are this diff and D14288 on hold indefinitely? we're hitting some growing pains and would love to have circle ci results in diffs, so debating if we should wait a month or just go ahead and roll our own hacky hooks

We're waiting on CircleCI, you'd have to ask them if you want a timeline.

As soon as CircleCI builds tags, I'll point this at whatever the new API is and land it.

got it, will send them a ping :)

This revision was automatically updated to reflect the committed changes.