Page MenuHomePhabricator
Differential D14255

Update Harbormaster for handleRequest
ClosedPublic
Actions

Authored by chad on Oct 12 2015, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 3:45 AM
Unknown Object (File)
Sat, Feb 8, 11:31 PM
Unknown Object (File)
Sat, Feb 8, 11:31 PM
Unknown Object (File)
Sat, Feb 8, 11:31 PM
Unknown Object (File)
Sat, Feb 8, 11:31 PM
Unknown Object (File)
Wed, Feb 5, 12:08 AM
Unknown Object (File)
Sat, Feb 1, 2:43 AM
Unknown Object (File)
Mon, Jan 27, 4:09 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rP02f42628c3ba: Update Harbormaster for handleRequest
Summary

Updates Harbormaster for handleRequest over processRequest

Test Plan

Went through various Harbormaster areas, buildables, actions.

Diff Detail

Repository
rP Phabricator
Branch
harb-proc
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8232
Build 9417: Run Core Tests
Build 9416: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34417.Oct 12 2015, 3:35 PM
chad retitled this revision from to Update Harbormaster for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 12 2015, 3:35 PM
epriestley accepted this revision.Oct 12 2015, 6:19 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 12 2015, 6:19 PM
Closed by commit rP02f42628c3ba: Update Harbormaster for handleRequest (authored by chad, committed by chad). · Explain WhyOct 12 2015, 6:39 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.Oct 18 2015, 6:57 AM

Revision Contents
Changeset List

Diff 34417

View Options

src/applications/harbormaster/controller/HarbormasterBuildActionController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableListController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepEditController.php

Loading...
Phabricator · Built by Phacility