Page MenuHomePhabricator
Differential D14252

Update Differential for handleRequest
ClosedPublic
Actions

Authored by chad on Oct 11 2015, 3:20 AM.
Tags
None
Referenced Files
F13850712: D14252.diff
Sat, Sep 28, 10:39 PM
Unknown Object (File)
Thu, Sep 5, 10:18 PM
Unknown Object (File)
Wed, Sep 4, 7:08 PM
Unknown Object (File)
Sat, Aug 31, 7:03 PM
Unknown Object (File)
Sat, Aug 31, 10:23 AM
Unknown Object (File)
Sat, Aug 31, 9:48 AM
Unknown Object (File)
Sat, Aug 31, 9:48 AM
Unknown Object (File)
Sat, Aug 31, 9:47 AM
View All Files
Subscribers
Korvin
Tokens
"Like" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rPbb37ad65a2b7: Update Differential for handleRequest
Summary

Moves from processRequest to handleRequest.

Test Plan

New diff, edit diff, leave comment, view list, browse revisions, etc.

Diff Detail

Repository
rP Phabricator
Branch
diff-process
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8227
Build 9410: Run Core Tests
Build 9409: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34412.Oct 11 2015, 3:20 AM
chad retitled this revision from to Update Differential for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 11 2015, 3:20 AM
epriestley accepted this revision.Oct 11 2015, 11:46 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 11 2015, 11:46 AM
epriestley awarded a token.Oct 11 2015, 11:46 AM
Closed by commit rPbb37ad65a2b7: Update Differential for handleRequest (authored by chad, committed by chad). · Explain WhyOct 11 2015, 3:18 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.Oct 18 2015, 6:55 AM

Revision Contents
Changeset List

Diff 34412

View Options

src/applications/differential/controller/DifferentialCommentPreviewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialCommentSaveController.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionEditController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionLandController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionListController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
Phabricator · Built by Phacility