Paths

Table of Contentst

Fix unit test errors in libphutil
ClosedPublic
Actions

Authored by epriestley on Oct 4 2015, 1:52 PM.

Details

Reviewers

joshuaspence
chad

Commits

rPHU21ee3ad4ba5f: Fix unit test errors in libphutil

Summary

Now that we have automatic builds, libphutil is failing because these tests aren't working.

A while ago, we changed xhpast to parse the <?php token a bit differently. Some of the highlighting stuff needs to be updated for it.

Test Plan

Ran arc unit --everything.

Diff Detail

Repository

rPHU libphutil

Branch

unit1

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/markup/engine/__tests__/remarkup/quoted-code-block.txt:10	TXT3	Line Too Long
Warning	src/markup/engine/__tests__/remarkup/quoted-code-block.txt:11	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 8173
Build 9337: Run Core Tests
Build 9336: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34362.Oct 4 2015, 1:52 PM

epriestley retitled this revision from to Fix unit test errors in libphutil.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, joshuaspence.

chad accepted this revision.Oct 4 2015, 2:37 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 4 2015, 2:37 PM

Closed by commit rPHU21ee3ad4ba5f: Fix unit test errors in libphutil (authored by epriestley, committed by epriestley). · Explain WhyOct 4 2015, 3:12 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D14069: Fix some failing unit tests.Nov 2 2015, 10:21 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

markup/

engine/

__tests__/

remarkup/

quoted-code-block.txt

4 lines

syntax/

highlighter/

__tests__/

PhutilXHPASTSyntaxHighlighterTestCase.php

2 lines

xhpast/

builtin-classname.expect

4 lines

multiline-token.expect

4 lines

trailing-comment.expect

5 lines

trailing-comment.source

2 lines

Diff 34362

View Options

src/__phutil_library_map__.php

View Options

src/markup/engine/tests/remarkup/quoted-code-block.txt

View Options

src/markup/syntax/highlighter/tests/PhutilXHPASTSyntaxHighlighterTestCase.php

View Options

src/markup/syntax/highlighter/tests/xhpast/builtin-classname.expect

View Options

src/markup/syntax/highlighter/tests/xhpast/multiline-token.expect

View Options

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.expect

View Options

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.source

Fix unit test errors in libphutilClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34362

src/__phutil_library_map__.php

src/markup/engine/__tests__/remarkup/quoted-code-block.txt

src/markup/syntax/highlighter/__tests__/PhutilXHPASTSyntaxHighlighterTestCase.php

src/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect

src/markup/syntax/highlighter/__tests__/xhpast/multiline-token.expect

src/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.expect

src/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.source

Fix unit test errors in libphutil
ClosedPublic
Actions

Revision Contents
Changeset List

src/markup/engine/tests/remarkup/quoted-code-block.txt

src/markup/syntax/highlighter/tests/PhutilXHPASTSyntaxHighlighterTestCase.php

src/markup/syntax/highlighter/tests/xhpast/builtin-classname.expect

src/markup/syntax/highlighter/tests/xhpast/multiline-token.expect

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.expect

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.source