Paths

Table of Contentst

Differential D14069

Fix some failing unit tests
AbandonedPublic
Actions

Authored by joshuaspence on Sep 6 2015, 4:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	May 25 2025, 6:29 AM

	Unknown Object (File)
	May 21 2025, 8:27 AM

	Unknown Object (File)
	Apr 23 2025, 5:20 AM

	Unknown Object (File)
	Apr 22 2025, 8:19 AM

	Unknown Object (File)
	Apr 19 2025, 11:12 AM

	Unknown Object (File)
	Apr 18 2025, 7:16 AM

	Unknown Object (File)
	Apr 14 2025, 10:24 AM

	Unknown Object (File)
	Apr 13 2025, 4:23 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

I have no idea why these are failing?

Test Plan

arc unit --everything

Diff Detail

Repository

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.expect:2	TXT4	File Does Not End in Newline
Warning	src/markup/engine/__tests__/remarkup/quoted-code-block.txt:10	TXT3	Line Too Long
Warning	src/markup/engine/__tests__/remarkup/quoted-code-block.txt:11	TXT3	Line Too Long

Unit

No Test Coverage

Build Status

Buildable 7926
Build 8881: [Placeholder Plan] Wait for 30 Seconds
Build 8880: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 34009.Sep 6 2015, 4:14 AM

joshuaspence retitled this revision from to Fix some failing unit tests.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2015, 4:14 AM

Herald added a subscriber: Korvin. · View Herald Transcript

These are because you changed how these things get parsed in XHPAST, right? Before the whitespace was part of the token and it no longer is?

This revision is now accepted and ready to land.Sep 6 2015, 2:59 PM

Oh right, of course.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Superseded by D14230.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

quoted-code-block.txt

4 lines

syntax/

highlighter/

__tests__/

xhpast/

builtin-classname.expect

4 lines

multiline-token.expect

4 lines

trailing-comment.expect

4 lines

Diff 34009

src/markup/engine/tests/remarkup/quoted-code-block.txt

Loading...

src/markup/syntax/highlighter/tests/xhpast/builtin-classname.expect

Loading...

src/markup/syntax/highlighter/tests/xhpast/multiline-token.expect

Loading...

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.expect

Loading...