Page MenuHomePhabricator

Allow Harbormaster build plans to request additional working copies
ClosedPublic

Authored by epriestley on Sep 28 2015, 11:39 PM.
Tags
None
Referenced Files
F13140890: D14183.diff
Fri, May 3, 4:00 AM
Unknown Object (File)
Mon, Apr 29, 4:14 PM
Unknown Object (File)
Wed, Apr 24, 11:58 PM
Unknown Object (File)
Fri, Apr 19, 3:39 PM
Unknown Object (File)
Tue, Apr 16, 12:20 PM
Unknown Object (File)
Wed, Apr 10, 8:59 PM
Unknown Object (File)
Tue, Apr 9, 7:21 PM
Unknown Object (File)
Apr 2 2024, 7:39 AM
Subscribers
None

Details

Summary

Ref T9123. To run upstream builds in Harbormaster/Drydock, we need to be able to check out libphutil, arcanist and phabricator next to one another.

This adds an "Also Clone: ..." field to Harbormaster working copy build steps so I can type all three repos into it and get a proper clone with everything we need.

This is somewhat upstream-centric and a bit narrow, but I don't think it's totally unreasonable, and most of the underlying stuff is relatively general.

This adds some more typechecking and improves data/type handling for custom fields, too. In particular, it prevents users from entering an invalid/restricted value in a field (for example, you can't "Also Clone" a repository you don't have permission to see).

Test Plan

Restarted build, got a Drydock resource with multiple repositories in it.

Diff Detail

Repository
rP Phabricator
Branch
drydock25
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8078
Build 9188: [Placeholder Plan] Wait for 30 Seconds
Build 9187: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow Harbormaster build plans to request additional working copies.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Specifically, you just get this nice little field that you can type repositories into:

Screen Shot 2015-09-28 at 4.44.34 PM.png (520×1 px, 52 KB)

chad edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2015, 12:56 AM
This revision was automatically updated to reflect the committed changes.