Differential D13991

Recover from PyLint raising messages at character "-1"
ClosedPublic
Actions

Authored by epriestley on Aug 25 2015, 3:39 AM.

Tags

None

Referenced Files

	F15389529: D13991.diff
	Sat, Mar 15, 5:22 AM

	F15378105: D13991.id33814.diff
	Thu, Mar 13, 12:50 PM

	Unknown Object (File)
	Tue, Feb 18, 9:21 AM

	Unknown Object (File)
	Tue, Feb 18, 7:56 AM

	Unknown Object (File)
	Feb 8 2025, 10:33 PM

	Unknown Object (File)
	Feb 2 2025, 3:51 AM

	Unknown Object (File)
	Jan 28 2025, 7:58 PM

	Unknown Object (File)
	Jan 28 2025, 8:52 AM

Subscribers

None

Details

Reviewers

joshuaspence
chad

Maniphest Tasks

T9257: Error: Parameter passed to "setChar()" must be an integer. when using ArcanistPyLintLinter.

Commits

rARC43f8e7eb7119: Recover from PyLint raising messages at character "-1"

Summary

Fixes T9257. For some messages, PyLint can raise at "character -1", which we don't allow since we don't consider it to make sense.

Test Plan

Added failing unit test from T9257.
Applied patch.
Test now passes.

Diff Detail

Repository

Branch

pylint1

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7810
Build 8652: [Placeholder Plan] Wait for 30 Seconds
Build 8651: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	812 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	19 ms	ArcanistXMLLinterTestCase::Unknown Unit Message ("")
	13 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	0 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
	0 ms	ArcanistCpplintLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 24 Passed · 29 Skipped)

Event Timeline

epriestley updated this revision to Diff 33811.Aug 25 2015, 3:39 AM

epriestley retitled this revision from to Recover from PyLint raising messages at character "-1".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, joshuaspence.

epriestley added a task: T9257: Error: Parameter passed to "setChar()" must be an integer. when using ArcanistPyLintLinter..

chad accepted this revision.Aug 25 2015, 3:40 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 25 2015, 3:40 AM

epriestley mentioned this in D13992: Remove two problematic XML linter unit tests.Aug 25 2015, 3:50 AM

joshuaspence accepted this revision.Aug 25 2015, 3:52 AM

joshuaspence edited edge metadata.

epriestley mentioned this in rARC1d3266395f70: Remove two problematic XML linter unit tests.Aug 25 2015, 4:07 AM

Clean unit results.
I had to strip one more XML test, see D13992 + T9258 for context.

Closed by commit rARC43f8e7eb7119: Recover from PyLint raising messages at character "-1" (authored by epriestley, committed by epriestley). · Explain WhyAug 25 2015, 4:11 AM

This revision was automatically updated to reflect the committed changes.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPyLintLinter.php

7 lines

__tests__/

pylint/

negativechar.lint-test

6 lines

Diff 33811

src/lint/linter/ArcanistPyLintLinter.php

Loading...

src/lint/linter/tests/pylint/negativechar.lint-test

Loading...