Page MenuHomePhabricator

Recover from PyLint raising messages at character "-1"
ClosedPublic

Authored by epriestley on Aug 25 2015, 3:39 AM.

Details

Summary

Fixes T9257. For some messages, PyLint can raise at "character -1", which we don't allow since we don't consider it to make sense.

Test Plan
  • Added failing unit test from T9257.
  • Applied patch.
  • Test now passes.

Diff Detail

Repository
rARC Arcanist
Branch
pylint1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 7810
Build 8652: [Placeholder Plan] Wait for 30 Seconds
Build 8651: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Recover from PyLint raising messages at character "-1".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 25 2015, 3:40 AM
epriestley edited edge metadata.
  • Clean unit results.
  • I had to strip one more XML test, see D13992 + T9258 for context.
This revision was automatically updated to reflect the committed changes.