Page MenuHomePhabricator
Differential D13991

Recover from PyLint raising messages at character "-1"
ClosedPublic
Actions

Authored by epriestley on Aug 25 2015, 3:39 AM.
Tags
None
Referenced Files
F13100762: D13991.diff
Fri, Apr 26, 7:59 PM
F13097487: D13991.id33815.diff
Fri, Apr 26, 12:46 AM
Unknown Object (File)
Thu, Apr 25, 2:59 PM
Unknown Object (File)
Thu, Apr 11, 7:26 AM
Unknown Object (File)
Tue, Apr 2, 4:44 PM
Unknown Object (File)
Sun, Mar 31, 2:07 AM
Unknown Object (File)
Thu, Mar 28, 4:46 PM
Unknown Object (File)
Thu, Mar 28, 9:28 AM
View All Files
Subscribers
None

Details

Reviewers
joshuaspence
chad
Maniphest Tasks
T9257: Error: Parameter passed to "setChar()" must be an integer. when using ArcanistPyLintLinter.
Commits
rARC43f8e7eb7119: Recover from PyLint raising messages at character "-1"
Summary

Fixes T9257. For some messages, PyLint can raise at "character -1", which we don't allow since we don't consider it to make sense.

Test Plan
  • Added failing unit test from T9257.
  • Applied patch.
  • Test now passes.

Diff Detail

Repository
rARC Arcanist
Branch
pylint1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7812
Build 8656: [Placeholder Plan] Wait for 30 Seconds
Build 8655: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33811.Aug 25 2015, 3:39 AM
epriestley retitled this revision from to Recover from PyLint raising messages at character "-1".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
epriestley added a task: T9257: Error: Parameter passed to "setChar()" must be an integer. when using ArcanistPyLintLinter..
chad accepted this revision.Aug 25 2015, 3:40 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 25 2015, 3:40 AM
epriestley mentioned this in D13992: Remove two problematic XML linter unit tests.Aug 25 2015, 3:50 AM
joshuaspence accepted this revision.Aug 25 2015, 3:52 AM
joshuaspence edited edge metadata.
epriestley mentioned this in rARC1d3266395f70: Remove two problematic XML linter unit tests.Aug 25 2015, 4:07 AM
epriestley updated this revision to Diff 33814.Aug 25 2015, 4:10 AM
epriestley edited edge metadata.
  • Clean unit results.
  • I had to strip one more XML test, see D13992 + T9258 for context.
Closed by commit rARC43f8e7eb7119: Recover from PyLint raising messages at character "-1" (authored by epriestley, committed by epriestley). · Explain WhyAug 25 2015, 4:11 AM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
7 lines
__tests__/
pylint/
6 lines
xml/

Diff 33814

View Options

src/lint/linter/ArcanistPyLintLinter.php

Loading...
View Options

src/lint/linter/__tests__/pylint/negativechar.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-7.lint-test

Loading...
Phabricator · Built by Phacility