Page MenuHomePhabricator
Differential D13973

Remove some unused fields from yy_extra_type
ClosedPublic
Actions

Authored by joshuaspence on Aug 23 2015, 5:35 AM.
Tags
None
Referenced Files
F19304182: D13973.id33713.diff
Wed, Dec 24, 7:43 AM
F19219572: D13973.id33713.diff
Dec 17 2025, 10:23 AM
F19136021: D13973.id33713.diff
Dec 10 2025, 9:15 AM
F19074254: D13973.id.diff
Dec 1 2025, 4:46 AM
F18851902: D13973.id.diff
Oct 31 2025, 5:04 AM
F18848500: D13973.diff
Oct 30 2025, 5:01 AM
F18772005: D13973.id.diff
Oct 8 2025, 11:32 PM
F18737317: D13973.diff
Oct 1 2025, 10:05 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU04f31e16d0b5: Remove some unused fields from yy_extra_type
Summary

These fields are no longer used after D1319. Removed them should save some precious bytes.

Test Plan

Ran arc unit -- src/parser/xhpast/__tests__/PHPASTParserTestCase.php.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7735
Build 8503: [Placeholder Plan] Wait for 30 Seconds
Build 8502: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33711.Aug 23 2015, 5:35 AM
joshuaspence retitled this revision from to Remove some unused fields from yy_extra_type.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 5:35 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence added a parent revision: D13969: Remove flex and bison debug flags.Aug 23 2015, 5:35 AM
joshuaspence updated this revision to Diff 33713.Aug 23 2015, 7:43 AM
joshuaspence edited edge metadata.

Bump version

epriestley accepted this revision.Aug 23 2015, 2:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 23 2015, 2:06 PM
Closed by commit rPHU04f31e16d0b5: Remove some unused fields from yy_extra_type (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 23 2015, 9:09 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
parser/
xhpast/
bin/
2 lines20%
Loading...
support/
xhpast/
14 lines--
7 lines--
977 lines--
6 lines--
6 lines--
2 lines--

Diff 33713

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility