Differential D13971

Fix bison "empty" warnings
ClosedPublic
Actions

Authored by joshuaspence on Aug 23 2015, 2:20 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUe456246d5446: Fix bison "empty" warnings

Summary

See https://www.gnu.org/software/bison/manual/html_node/Empty-Rules.html. Depends on D13970.

Test Plan

Less warnings.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7730
Build 8493: [Placeholder Plan] Wait for 30 Seconds
Build 8492: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33708.Aug 23 2015, 2:20 AM

joshuaspence retitled this revision from to Fix bison "empty" warnings.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 2:20 AM

Herald added a subscriber: Korvin. · View Herald Transcript

joshuaspence updated this object.Aug 23 2015, 7:44 AM

joshuaspence edited edge metadata.

joshuaspence added a parent revision: D13970: Enable bison warnings.

epriestley accepted this revision.Aug 23 2015, 2:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 23 2015, 2:06 PM

Closed by commit rPHUe456246d5446: Fix bison "empty" warnings (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 23 2015, 9:03 PM

This revision was automatically updated to reflect the committed changes.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

support/

xhpast/

parser.y

66 lines

Diff 33708

View Options

Fix bison "empty" warningsClosedPublicActions