Page MenuHomePhabricator
Differential D13970

Enable bison warnings
ClosedPublic
Actions

Authored by joshuaspence on Aug 23 2015, 2:19 AM.
Tags
None
Referenced Files
F19278314: D13970.diff
Tue, Dec 23, 2:23 AM
F19219665: D13970.id.diff
Dec 17 2025, 10:27 AM
F18904235: D13970.id.diff
Nov 8 2025, 8:18 AM
F18844367: D13970.id33730.diff
Oct 29 2025, 4:56 AM
F18771052: D13970.id33707.diff
Oct 8 2025, 5:07 PM
F18732497: D13970.diff
Sep 30 2025, 6:28 PM
F18732466: D13970.diff
Sep 30 2025, 6:21 PM
F18732154: D13970.diff
Sep 30 2025, 4:40 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU3cdc554b99cf: Enable bison warnings
Summary

Pass the -Wall flag to bison to show warnings.

Test Plan

Ran make -C support/xhpast parser and saw warnings.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsupport/xhpast/Makefile:6TXT2Tab Literal
Unit
No Test Coverage
Build Status
Buildable 7729
Build 8491: [Placeholder Plan] Wait for 30 Seconds
Build 8490: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33707.Aug 23 2015, 2:19 AM
joshuaspence retitled this revision from to Enable bison warnings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 2:19 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Aug 23 2015, 3:52 AM
joshuaspence edited edge metadata.
joshuaspence added a parent revision: D13969: Remove flex and bison debug flags.Aug 23 2015, 5:22 AM
joshuaspence added a child revision: D13971: Fix bison "empty" warnings.Aug 23 2015, 7:44 AM
joshuaspence added a child revision: D13974: Fix bison warnings.Aug 23 2015, 8:12 AM
epriestley accepted this revision.Aug 23 2015, 2:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 23 2015, 2:07 PM
Closed by commit rPHU3cdc554b99cf: Enable bison warnings (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 23 2015, 9:02 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM
epriestley mentioned this in T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.Apr 7 2020, 2:08 PM
epriestley mentioned this in D21063: Revert xhpast changes that impacted builds under Bison 2.3.Apr 7 2020, 9:02 PM
epriestley mentioned this in rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3.Apr 7 2020, 9:29 PM

Revision Contents
Changeset List

PathSize
support/
xhpast/
2 lines

Diff 33707

View Options

support/xhpast/Makefile

Loading...
Phabricator · Built by Phacility