Fixes T8428. Adds status to packages, allows setting and application search. I presume though these need checked elsewhere?
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T8428: Allow packages to be disabled
- Commits
- Restricted Diffusion Commit
rPe0faa66772ed: Allow Owners Packages to be archived
New package, edit package, archive package, run search queries.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- owners-archive
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7671 Build 8379: [Placeholder Plan] Wait for 30 Seconds Build 8378: arc lint + arc unit
Event Timeline
Comment Actions
Three more places where you can drop this in easily are:
- PhabricatorOwnersPackageQuery, both PhabricatorOwnersPackageQuery queries in buildTableOfContents().
- DifferentialController, both queries in buildTableOfContents().
- DiffusionBrowseController, the one PhabricatorOwnersPackageQuery.
There are some other places where it should work too, but they likely need to get modernized a bit first. I can clean them up as I work through them.
| src/applications/owners/controller/PhabricatorOwnersEditController.php | ||
|---|---|---|
| 129 | (Weird indent?) | |
| src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php | ||
| 121–123 | This should be impossible, I think? | |