Page MenuHomePhabricator

Allow Owners Packages to be archived
ClosedPublic

Authored by chad on Aug 17 2015, 8:02 PM.
Tags
None
Referenced Files
F13092565: D13925.diff
Thu, Apr 25, 3:50 AM
Unknown Object (File)
Sat, Apr 20, 8:42 PM
Unknown Object (File)
Tue, Apr 16, 5:41 PM
Unknown Object (File)
Tue, Apr 16, 5:19 AM
Unknown Object (File)
Tue, Apr 16, 5:19 AM
Unknown Object (File)
Tue, Apr 16, 5:19 AM
Unknown Object (File)
Thu, Apr 11, 11:13 AM
Unknown Object (File)
Sun, Apr 7, 1:12 PM
Subscribers

Details

Summary

Fixes T8428. Adds status to packages, allows setting and application search. I presume though these need checked elsewhere?

Test Plan

New package, edit package, archive package, run search queries.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Allow Owners Packages to be archived.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Three more places where you can drop this in easily are:

  • PhabricatorOwnersPackageQuery, both PhabricatorOwnersPackageQuery queries in buildTableOfContents().
  • DifferentialController, both queries in buildTableOfContents().
  • DiffusionBrowseController, the one PhabricatorOwnersPackageQuery.

There are some other places where it should work too, but they likely need to get modernized a bit first. I can clean them up as I work through them.

src/applications/owners/controller/PhabricatorOwnersEditController.php
129

(Weird indent?)

src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php
121–123

This should be impossible, I think?

This revision is now accepted and ready to land.Aug 17 2015, 10:23 PM
chad marked an inline comment as done.Aug 18 2015, 8:22 PM

Three more places where you can drop this in easily are:

  • PhabricatorOwnersPackageQuery, both PhabricatorOwnersPackageQuery queries in buildTableOfContents().

^^ couldn't find this?

chad edited edge metadata.
  • update per comments

haha sorry, let me get you the actual thingie

First one should be in DiffusionCommitController, I just derped the copy/paste.

This revision was automatically updated to reflect the committed changes.