Paths

Table of Contentst

Differential D13889

Add a `getLineNumber()` method to `AASTToken`
ClosedPublic
Actions

Authored by joshuaspence on Aug 13 2015, 9:57 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU9c64e4ee00a6: Add a `getLineNumber()` method to `AASTToken`

Summary

Adds an AASTToken::getLineNumber() method, similar to AASTNode::getLineNumber().

Test Plan

See D13534.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7618
Build 8276: [Placeholder Plan] Wait for 30 Seconds
Build 8275: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33532.Aug 13 2015, 9:57 PM

joshuaspence retitled this revision from to Add a `getLineNumber()` method to `AASTToken`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 13 2015, 9:57 PM

Herald added a subscriber: Korvin. · View Herald Transcript

joshuaspence added a child revision: D13534: Add a linter rule for newlines after PHP open tags.Aug 13 2015, 10:21 PM

epriestley accepted this revision.Aug 27 2015, 11:47 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 27 2015, 11:47 AM

Closed by commit rPHU9c64e4ee00a6: Add a `getLineNumber()` method to `AASTToken` (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 27 2015, 12:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

parser/

aast/

api/

AASTToken.php

4 lines

Diff 33532

View Options

src/parser/aast/api/AASTToken.php

Add a `getLineNumber()` method to `AASTToken`ClosedPublicActions