Details

Reviewers

Group Reviewers

Commits

rPHUd052c489a283: Include parentheses in n_ARRAY_VALUE_LIST node

Summary

Currently parsing array(1, 2, 3) results in a n_ARRAY_VALUE_LIST with a concrete string of 1, 2, 3. Compare this to list($x, $y) which results in a n_ASSIGNMENT_LIST with a concrete string of ($x, $y).

Test Plan

See next diff.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7590
Build 8220: [Placeholder Plan] Wait for 30 Seconds
Build 8219: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33473.Aug 11 2015, 10:54 AM

joshuaspence retitled this revision from to Include parentheses in n_ARRAY_VALUE_LIST node.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 10:54 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Fix for list($i, list($j, $k)) = y()

joshuaspence added a child revision: D13859: Improve linter rules for array formatting.Aug 11 2015, 11:42 AM

Also bump version?

This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM

Update tests

Bump XHPAST version

Closed by commit rPHUd052c489a283: Include parentheses in n_ARRAY_VALUE_LIST node (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 11 2015, 12:34 PM

This revision was automatically updated to reflect the committed changes.

Include parentheses in n_ARRAY_VALUE_LIST node
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 33482

src/parser/xhpast/tests/data/php-array-dereference.expect

src/parser/xhpast/tests/data/php-literal-index.php.expect

src/parser/xhpast/tests/data/php-short-array.php.expect

src/parser/xhpast/tests/data/php-syntax.php.expect

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

Include parentheses in n_ARRAY_VALUE_LIST nodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33482

src/parser/xhpast/__tests__/data/php-array-dereference.expect

src/parser/xhpast/__tests__/data/php-literal-index.php.expect

src/parser/xhpast/__tests__/data/php-short-array.php.expect

src/parser/xhpast/__tests__/data/php-syntax.php.expect

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

Include parentheses in n_ARRAY_VALUE_LIST node
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/php-array-dereference.expect

src/parser/xhpast/tests/data/php-literal-index.php.expect

src/parser/xhpast/tests/data/php-short-array.php.expect

src/parser/xhpast/tests/data/php-syntax.php.expect