Fixes T9078, Adds SubscribableInterface to Passphrase.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T9078: Allow Passphrase credentials to be subscribbable
- Commits
- Restricted Diffusion Commit
rPb34dc6164af2: Add Subscribers to Passphrase
Create a new passphrase, see myself subscribed. Subscribe to other Passphrases.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- pass-sub
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7496 Build 8032: [Placeholder Plan] Wait for 30 Seconds Build 8031: arc lint + arc unit
Event Timeline
| src/applications/passphrase/storage/PassphraseCredential.php | ||
|---|---|---|
| 156 | Maybe omit this (just return false;) because we don't give the author any other special privileges for these object types. In particular, if you're in charge of Twitter and move to the Devops team, it's reasonable to revoke your access to a Twitter credential even if you created it. It seems correct to sever the author from the credential completely at this point. | |