Page MenuHomePhabricator

Add Subscribers to Passphrase
ClosedPublic

Authored by chad on Aug 5 2015, 6:55 PM.

Details

Summary

Fixes T9078, Adds SubscribableInterface to Passphrase.

Test Plan

Create a new passphrase, see myself subscribed. Subscribe to other Passphrases.

Diff Detail

Repository
rP Phabricator
Branch
pass-sub
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 7496
Build 8032: [Placeholder Plan] Wait for 30 Seconds
Build 8031: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33325.Aug 5 2015, 6:55 PM
chad retitled this revision from to Add Subscribers to Passphrase.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley added inline comments.Aug 5 2015, 6:56 PM
src/applications/passphrase/storage/PassphraseCredential.php
156

Maybe omit this (just return false;) because we don't give the author any other special privileges for these object types.

In particular, if you're in charge of Twitter and move to the Devops team, it's reasonable to revoke your access to a Twitter credential even if you created it. It seems correct to sever the author from the credential completely at this point.

epriestley accepted this revision.Aug 5 2015, 6:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 5 2015, 6:56 PM
chad updated this revision to Diff 33326.Aug 5 2015, 6:58 PM
chad marked an inline comment as done.
chad edited edge metadata.
  • Twitter team gots no chill
This revision was automatically updated to reflect the committed changes.