Page MenuHomePhabricator
Differential D13799

Add Subscribers to Passphrase
ClosedPublic
Actions

Authored by chad on Aug 5 2015, 6:55 PM.
Tags
None
Referenced Files
F13053692: D13799.diff
Fri, Apr 19, 11:24 AM
Unknown Object (File)
Fri, Apr 12, 9:23 PM
Unknown Object (File)
Thu, Apr 11, 8:19 AM
Unknown Object (File)
Sat, Apr 6, 4:32 AM
Unknown Object (File)
Sat, Apr 6, 4:32 AM
Unknown Object (File)
Thu, Apr 4, 1:32 AM
Unknown Object (File)
Fri, Mar 29, 1:09 PM
Unknown Object (File)
Fri, Mar 29, 4:37 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9078: Allow Passphrase credentials to be subscribbable
Commits
Restricted Diffusion Commit
rPb34dc6164af2: Add Subscribers to Passphrase
Summary

Fixes T9078, Adds SubscribableInterface to Passphrase.

Test Plan

Create a new passphrase, see myself subscribed. Subscribe to other Passphrases.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33325.Aug 5 2015, 6:55 PM
chad retitled this revision from to Add Subscribers to Passphrase.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9078: Allow Passphrase credentials to be subscribbable.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 5 2015, 6:55 PM
epriestley added inline comments.Aug 5 2015, 6:56 PM
src/applications/passphrase/storage/PassphraseCredential.php
156

Maybe omit this (just return false;) because we don't give the author any other special privileges for these object types.

In particular, if you're in charge of Twitter and move to the Devops team, it's reasonable to revoke your access to a Twitter credential even if you created it. It seems correct to sever the author from the credential completely at this point.

epriestley accepted this revision.Aug 5 2015, 6:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 5 2015, 6:56 PM
chad updated this revision to Diff 33326.Aug 5 2015, 6:58 PM
chad marked an inline comment as done.
chad edited edge metadata.
  • Twitter team gots no chill
Closed by commit rPb34dc6164af2: Add Subscribers to Passphrase (authored by chad, committed by chad). · Explain WhyAug 5 2015, 6:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
applications/
passphrase/
controller/
2 lines
storage/
18 lines

Diff 33327

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
Phabricator · Built by Phacility