Page MenuHomePhabricator

Add Subscribers to Passphrase
ClosedPublic

Authored by chad on Aug 5 2015, 6:55 PM.
Tags
None
Referenced Files
F12808475: D13799.id33326.diff
Wed, Mar 27, 8:35 PM
Unknown Object (File)
Sat, Mar 16, 6:53 AM
Unknown Object (File)
Thu, Feb 29, 11:38 PM
Unknown Object (File)
Feb 24 2024, 8:36 AM
Unknown Object (File)
Feb 21 2024, 5:24 AM
Unknown Object (File)
Feb 3 2024, 6:09 AM
Unknown Object (File)
Feb 3 2024, 6:09 AM
Unknown Object (File)
Feb 3 2024, 6:09 AM
Subscribers

Details

Summary

Fixes T9078, Adds SubscribableInterface to Passphrase.

Test Plan

Create a new passphrase, see myself subscribed. Subscribe to other Passphrases.

Diff Detail

Repository
rP Phabricator
Branch
pass-sub
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7495
Build 8030: [Placeholder Plan] Wait for 30 Seconds
Build 8029: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add Subscribers to Passphrase.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
src/applications/passphrase/storage/PassphraseCredential.php
156

Maybe omit this (just return false;) because we don't give the author any other special privileges for these object types.

In particular, if you're in charge of Twitter and move to the Devops team, it's reasonable to revoke your access to a Twitter credential even if you created it. It seems correct to sever the author from the credential completely at this point.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 5 2015, 6:56 PM
chad marked an inline comment as done.
chad edited edge metadata.
  • Twitter team gots no chill
This revision was automatically updated to reflect the committed changes.