Page MenuHomePhabricator

Don't reset message if missing Room Title in New Conpherence Room
ClosedPublic

Authored by chad on Jul 29 2015, 4:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 4:33 PM
Unknown Object (File)
Feb 11 2024, 11:20 AM
Unknown Object (File)
Feb 9 2024, 4:18 PM
Unknown Object (File)
Feb 9 2024, 4:17 PM
Unknown Object (File)
Feb 9 2024, 4:17 PM
Unknown Object (File)
Feb 9 2024, 4:02 PM
Unknown Object (File)
Feb 9 2024, 3:26 PM
Unknown Object (File)
Feb 7 2024, 7:05 PM
Subscribers

Details

Summary

Fixes T9000, sets a variable.

Test Plan

Try to make a new room without a title, but with a message.

Diff Detail

Repository
rP Phabricator
Branch
conph-new
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7447
Build 7934: [Placeholder Plan] Wait for 30 Seconds
Build 7933: arc lint + arc unit

Event Timeline

chad retitled this revision from to Don't reset message if missing Room Title in New Conpherence Room.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/conpherence/controller/ConpherenceNewRoomController.php
40

This test should probably be if (strlen($v_message)) -- users may not be able to send the message "0" (no quotes) otherwise because of PHP being special.

This revision is now accepted and ready to land.Jul 29 2015, 11:24 PM

I'm ok waiting until joshuaspence finds it.

chad marked an inline comment as done.
chad edited edge metadata.
  • strlen
This revision was automatically updated to reflect the committed changes.