Page MenuHomePhabricator

Don't reset message if missing Room Title in New Conpherence Room
ClosedPublic

Authored by chad on Jul 29 2015, 4:56 AM.
Tags
None
Referenced Files
F11412328: D13754.diff
Thu, Dec 8, 5:22 AM
Unknown Object (File)
Wed, Dec 7, 12:40 AM
Unknown Object (File)
Wed, Dec 7, 12:40 AM
Unknown Object (File)
Wed, Dec 7, 12:40 AM
Unknown Object (File)
Wed, Dec 7, 12:40 AM
Unknown Object (File)
Wed, Nov 16, 10:38 PM
Unknown Object (File)
Fri, Nov 11, 2:16 AM
Unknown Object (File)
Oct 28 2022, 12:59 PM
Subscribers

Details

Summary

Fixes T9000, sets a variable.

Test Plan

Try to make a new room without a title, but with a message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Don't reset message if missing Room Title in New Conpherence Room.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/conpherence/controller/ConpherenceNewRoomController.php
40

This test should probably be if (strlen($v_message)) -- users may not be able to send the message "0" (no quotes) otherwise because of PHP being special.

This revision is now accepted and ready to land.Jul 29 2015, 11:24 PM

I'm ok waiting until joshuaspence finds it.

chad marked an inline comment as done.
chad edited edge metadata.
  • strlen
This revision was automatically updated to reflect the committed changes.