Paths

Table of Contentst

Differential D13754

Don't reset message if missing Room Title in New Conpherence Room
ClosedPublic
Actions

Authored by chad on Jul 29 2015, 4:56 AM.

Tags

None

Referenced Files

	F13051928: D13754.id33221.diff
	Fri, Apr 19, 5:42 AM

	Unknown Object (File)
	Fri, Apr 12, 7:19 PM

	Unknown Object (File)
	Fri, Apr 12, 7:19 PM

	Unknown Object (File)
	Fri, Apr 12, 7:19 PM

	Unknown Object (File)
	Fri, Apr 12, 7:06 PM

	Unknown Object (File)
	Fri, Apr 12, 6:37 PM

	Unknown Object (File)
	Sun, Apr 7, 4:34 AM

	Unknown Object (File)
	Fri, Mar 29, 2:36 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T9000: Not entering a Name for a room loses the First Message section

Commits

Restricted Diffusion Commit
rP38259f0cc26f: Don't reset message if missing Room Title in New Conpherence Room

Summary

Fixes T9000, sets a variable.

Test Plan

Try to make a new room without a title, but with a message.

Diff Detail

Repository

Branch

conph-new

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7442
Build 7924: [Placeholder Plan] Wait for 30 Seconds
Build 7923: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33221.Jul 29 2015, 4:56 AM

chad retitled this revision from to Don't reset message if missing Room Title in New Conpherence Room.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9000: Not entering a Name for a room loses the First Message section.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 29 2015, 4:56 AM

epriestley accepted this revision.Jul 29 2015, 11:24 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/conpherence/controller/ConpherenceNewRoomController.php
40	This test should probably be `if (strlen($v_message))` -- users may not be able to send the message "0" (no quotes) otherwise because of PHP being special.

This revision is now accepted and ready to land.Jul 29 2015, 11:24 PM

I'm ok waiting until joshuaspence finds it.

strlen

Closed by commit rP38259f0cc26f: Don't reset message if missing Room Title in New Conpherence Room (authored by chad, committed by chad). · Explain WhyJul 30 2015, 12:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceNewRoomController.php

10 lines

Diff 33221

src/applications/conpherence/controller/ConpherenceNewRoomController.php

Loading...