Fixes T8982
Prevent empty parameters to overwrite default configuration
Details
Details
- Reviewers
joshuaspence epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx)
Start Arcanist with a notification.client-uri without port like htttp://localhost/ws
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- fix-T8982
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 7429 Build 7898: [Placeholder Plan] Wait for 30 Seconds Build 7897: arc lint + arc unit
Event Timeline
| support/aphlict/server/aphlict_server.js | ||
|---|---|---|
| 23 | Does the args comes in the following format ?? --test-me-please=i-will-do or rather in the followin format --'test-me-please'='i-will-do' If 2) the fix wont works | |
Comment Actions
@epriestley, @joshuaspence : is it possible to reveiw and merge this.
It is very simple it prevent --key=value to override default key if value is empty string.
It is related to T8982 which basically prevent aphlict to start when configured to https://phabricator.domaine.name/ws since in this case the port is null so defauted to 443 if https but after nginx routed it is wss protocol so at the end, an empty port replace the correct default aphlict server port !