HomePhabricator

Allow upload of arbitrary text files

Description

Allow upload of arbitrary text files

Summary:
Fixes T8984. Because of how drag-and-drop upload works, the text file with content code is interpreted as a forbidden variable. Disable this check for the drop upload controller.

(The risk here is a general one where the controller redirects and bundles paramters; this controller does not do that, so it's safe to make this change.)

Test Plan: Uploaded a text file containing only the string "code" (no quotes) by using drag-and-drop.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8984

Differential Revision: https://secure.phabricator.com/D13744

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jul 28 2015, 3:04 PM
Reviewer
chad
Differential Revision
D13744: Allow upload of arbitrary text files
Parents
rPeb152d3053a0: Allow Tokens on Badge
Branches
Unknown
Tags
Unknown
Tasks
T8984: Text files containing string "code" aren't allowed to upload via drag-n-drop