Page MenuHomePhabricator
Differential D13735

Update Files for handleRequest
ClosedPublic
Actions

Authored by chad on Jul 27 2015, 4:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 2:04 PM
Unknown Object (File)
Mon, Apr 22, 10:35 AM
Unknown Object (File)
Mon, Apr 22, 10:35 AM
Unknown Object (File)
Mon, Apr 22, 10:34 AM
Unknown Object (File)
Mon, Apr 22, 10:34 AM
Unknown Object (File)
Fri, Apr 12, 5:37 PM
Unknown Object (File)
Fri, Apr 12, 5:37 PM
Unknown Object (File)
Fri, Apr 12, 5:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rPe90379dd2d66: Update Files for handleRequest
Summary

Update Files application

Test Plan

Upload a file, edit a file, view details, transforms, delete file

Diff Detail

Repository
rP Phabricator
Branch
files-process
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7417
Build 7874: [Placeholder Plan] Wait for 30 Seconds
Build 7873: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33166.Jul 27 2015, 4:19 AM
chad retitled this revision from to Update Files for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 27 2015, 4:19 AM
epriestley accepted this revision.Jul 27 2015, 2:38 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/files/controller/PhabricatorFileInfoController.php
83

Or $this->getViewer().

179–180

Or $this->getViewer().

This revision is now accepted and ready to land.Jul 27 2015, 2:38 PM
chad updated this revision to Diff 33184.Jul 27 2015, 4:41 PM
chad marked 2 inline comments as done.
chad edited edge metadata.
  • comments
Closed by commit rPe90379dd2d66: Update Files for handleRequest (authored by chad, committed by chad). · Explain WhyJul 27 2015, 4:41 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.Oct 18 2015, 6:52 AM

Revision Contents
Changeset List

Diff 33166

View Options

src/applications/files/controller/PhabricatorFileCommentController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileComposeController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDataController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDeleteController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDropUploadController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileEditController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileUploadDialogController.php

Loading...
Phabricator · Built by Phacility