Allow People to be Flagged
ClosedPublic
Actions

Authored by chad on Jul 18 2015, 7:18 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8888: Ability to flag dashboards and users

Commits

Restricted Diffusion Commit
rPd83dce989333: Allow People to be Flagged

Summary

Ref T8888, Makes People Flaggable (and makes me wonder if we should rename Flags->Bookmarks).

Test Plan

Flag myself. Get excited.

Diff Detail

Repository

rP Phabricator

Branch

flag-people

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7310
Build 7660: [Placeholder Plan] Wait for 30 Seconds
Build 7659: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33002.Jul 18 2015, 7:18 PM

chad retitled this revision from to Allow People to be Flagged.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8888: Ability to flag dashboards and users.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 18 2015, 7:18 PM

As an aside, "flagging" a user sounds like something negative to me. Bookmark sounds much friendlier.

This change is technically correct.

Like @joshuaspence, I'm not totally sure I'm 100% onboard with it from a product perspective (it feels a little weird to me to flag users, too) but I guess the use case in T8888 looks legit enough. This does improve consistency and I don't think it's likely to be particularly confusing, even if it's maybe a little off product-wise.

This revision is now accepted and ready to land.Jul 20 2015, 8:23 PM

Closed by commit rPd83dce989333: Allow People to be Flagged (authored by chad, committed by chad). · Explain WhyJul 20 2015, 8:44 PM

This revision was automatically updated to reflect the committed changes.