Page MenuHomePhabricator
Differential D13644

Rename "HeraldAction" to "HeraldActionRecord"
ClosedPublic
Actions

Authored by epriestley on Jul 17 2015, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 10:22 AM
Unknown Object (File)
Mon, Apr 22, 8:20 AM
Unknown Object (File)
Mon, Apr 22, 8:20 AM
Unknown Object (File)
Wed, Apr 17, 2:18 PM
Unknown Object (File)
Sat, Apr 13, 3:15 AM
Unknown Object (File)
Thu, Apr 11, 5:33 PM
Unknown Object (File)
Sun, Apr 7, 4:21 PM
Unknown Object (File)
Mon, Apr 1, 1:59 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rPe0861bf240cf: Rename "HeraldAction" to "HeraldActionRecord"
Summary

Ref T8726. I want to modularize actions like fields, but the base class should be "HeraldAction".

Eventually, "HeraldCondition" should probably be "HeraldFieldRecord", and then both Action and Condition should just be rolled into Rule, probably, but that can wait and doesn't block anything.

Test Plan

Ran migration, poked around UI, used git grep.

Diff Detail

Repository
rP Phabricator
Branch
heraldx1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7299
Build 7638: [Placeholder Plan] Wait for 30 Seconds
Build 7637: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32988.Jul 17 2015, 3:19 PM
epriestley retitled this revision from to Rename "HeraldAction" to "HeraldActionRecord".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 17 2015, 3:19 PM
btrahan accepted this revision.Jul 20 2015, 6:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 20 2015, 6:12 PM
Closed by commit rPe0861bf240cf: Rename "HeraldAction" to "HeraldActionRecord" (authored by epriestley, committed by epriestley). · Explain WhyJul 23 2015, 8:26 PM
This revision was automatically updated to reflect the committed changes.
chad mentioned this in T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist).Jul 25 2015, 4:04 PM
epriestley mentioned this in D13736: Put the HeraldActionRecord table back on the shelf.Jul 27 2015, 2:54 PM
epriestley mentioned this in rP8d53f1511565: Put the HeraldActionRecord table back on the shelf.Jul 27 2015, 10:08 PM
epriestley mentioned this in rP04c40e3abf10: (stable) Put the HeraldActionRecord table back on the shelf.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
2 lines
src/
4 lines
applications/
herald/
adapter/
6 lines
controller/
2 lines
query/
2 lines
storage/
HeraldActionRecord.php
HeraldAction.php
2 lines
10 lines

Diff 32988

View Options

resources/sql/autopatches/20150606.mlist.1.php

Loading...
View Options

resources/sql/autopatches/20150717.herald.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/query/HeraldRuleQuery.php

Loading...
View Options

src/applications/herald/storage/HeraldAction.php

Loading...
View Options

src/applications/herald/storage/HeraldActionRecord.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility