Page MenuHomePhabricator
Differential D13736

Put the HeraldActionRecord table back on the shelf
ClosedPublic
Actions

Authored by epriestley on Jul 27 2015, 2:54 PM.
Tags
None
Referenced Files
F15416216: D13736.diff
Thu, Mar 20, 9:52 AM
F15386358: D13736.id33174.diff
Sat, Mar 15, 12:25 AM
F15337451: D13736.id33174.diff
Sun, Mar 9, 5:55 AM
F15337448: D13736.id33190.diff
Sun, Mar 9, 5:55 AM
F15337414: D13736.id.diff
Sun, Mar 9, 5:48 AM
F15337361: D13736.diff
Sun, Mar 9, 5:29 AM
F15334379: D13736.id33174.diff
Sat, Mar 8, 8:38 AM
Unknown Object (File)
Feb 8 2025, 9:46 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist)
Commits
Restricted Diffusion Commit
rP04c40e3abf10: (stable) Put the HeraldActionRecord table back on the shelf
rP8d53f1511565: Put the HeraldActionRecord table back on the shelf
Summary

Fixes T8958. I renamed this class and table (in D13644), but the migration 20150606.mlist.1.php needs to load records from the table before the table rename applies.

Put the table back and accept a tiny bit of cruft here to fix this problem. We can no-op the migration after a while.

I'll cherry-pick this to stable.

Test Plan

Applied migration. Created Herald rules. Reviewed existing Herald rules.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33174.Jul 27 2015, 2:54 PM
epriestley retitled this revision from to Put the HeraldActionRecord table back on the shelf.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist).
Herald added a subscriber: epriestley. · View Herald TranscriptJul 27 2015, 2:54 PM
Closed by commit rP8d53f1511565: Put the HeraldActionRecord table back on the shelf (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2015, 10:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
herald/
storage/
8 lines

Diff 33190

View Options

resources/sql/autopatches/20150727.heraldaction.1.sql

Loading...
View Options

src/applications/herald/storage/HeraldActionRecord.php

Loading...
Phabricator · Built by Phacility