Support "Select" custom fields in Herald rules
ClosedPublic
Actions

Authored by epriestley on Jul 9 2015, 10:07 PM.

Details

Reviewers

Maniphest Tasks

T655: Integrate CustomField into Herald
T5016: Allow Herald rules for Maniphest to act on custom task fields
T8434: Accommodate the "Security" workflow
T8726: Modularize Herald fields and actions

Commits

Restricted Diffusion Commit
rP97ccd936709c: Support "Select" custom fields in Herald rules

Summary

Fixes T5016. Ref T655. Ref T8434. Ref T8726. For "select" custom fields, permit construction of Herald rules.

Test Plan

Screen Shot 2015-07-09 at 3.06.26 PM.png (973×1 px, 153 KB)

Diff Detail

Repository

rP Phabricator

Branch

herald5

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/herald/controller/HeraldTranscriptController.php:119	XHP16	TODO Comment
Advice	src/applications/herald/value/HeraldTokenizerFieldValue.php:83	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 7235
Build 7512: [Placeholder Plan] Wait for 30 Seconds
Build 7511: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32900.Jul 9 2015, 10:07 PM

epriestley retitled this revision from to Support "Select" custom fields in Herald rules.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T8726: Modularize Herald fields and actions, T8434: Accommodate the "Security" workflow, T5016: Allow Herald rules for Maniphest to act on custom task fields, T655: Integrate CustomField into Herald.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 9 2015, 10:07 PM

btrahan accepted this revision.Jul 16 2015, 8:43 PM

btrahan awarded a token.

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jul 16 2015, 8:44 PM

Closed by commit rP97ccd936709c: Support "Select" custom fields in Herald rules (authored by epriestley, committed by epriestley). · Explain WhyJul 16 2015, 9:12 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T655: Integrate CustomField into Herald.Aug 12 2015, 10:34 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

herald/

adapter/

HeraldAdapter.php

47 lines

controller/

HeraldTranscriptController.php

13 lines

field/

HeraldField.php

57 lines

value/

HeraldEmptyFieldValue.php

4 lines

HeraldFieldValue.php

1 line

HeraldSelectFieldValue.php

4 lines

HeraldTextFieldValue.php

5 lines

HeraldTokenizerFieldValue.php

43 lines

maniphest/

herald/

ManiphestTaskPriorityHeraldField.php

32 lines

ManiphestTaskStatusHeraldField.php

32 lines

infrastructure/

customfield/

datasource/

PhabricatorStandardSelectCustomFieldDatasource.php

93 lines

standard/

PhabricatorStandardCustomFieldSelect.php

30 lines

Diff 32900

View Options

src/__phutil_library_map__.php

View Options

src/applications/herald/adapter/HeraldAdapter.php

View Options

src/applications/herald/controller/HeraldTranscriptController.php

View Options

src/applications/herald/field/HeraldField.php

View Options

src/applications/herald/value/HeraldEmptyFieldValue.php

View Options

src/applications/herald/value/HeraldFieldValue.php

View Options

src/applications/herald/value/HeraldSelectFieldValue.php

View Options

src/applications/herald/value/HeraldTextFieldValue.php

View Options

src/applications/herald/value/HeraldTokenizerFieldValue.php

View Options

src/applications/maniphest/herald/ManiphestTaskPriorityHeraldField.php

View Options

src/applications/maniphest/herald/ManiphestTaskStatusHeraldField.php

View Options

src/infrastructure/customfield/datasource/PhabricatorStandardSelectCustomFieldDatasource.php

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Support "Select" custom fields in Herald rulesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32900

src/__phutil_library_map__.php

src/applications/herald/adapter/HeraldAdapter.php

src/applications/herald/controller/HeraldTranscriptController.php

src/applications/herald/field/HeraldField.php

src/applications/herald/value/HeraldEmptyFieldValue.php

src/applications/herald/value/HeraldFieldValue.php

src/applications/herald/value/HeraldSelectFieldValue.php

src/applications/herald/value/HeraldTextFieldValue.php

src/applications/herald/value/HeraldTokenizerFieldValue.php

src/applications/maniphest/herald/ManiphestTaskPriorityHeraldField.php

src/applications/maniphest/herald/ManiphestTaskStatusHeraldField.php

src/infrastructure/customfield/datasource/PhabricatorStandardSelectCustomFieldDatasource.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Support "Select" custom fields in Herald rules
ClosedPublic
Actions

Revision Contents
Changeset List