Page MenuHomePhabricator
Differential D13596

Don't include debugging symbols in XHPAST by default
ClosedPublic
Actions

Authored by joshuaspence on Jul 8 2015, 7:31 AM.
Tags
None
Referenced Files
F13227348: D13596.id32855.diff
Mon, May 20, 2:51 AM
F13215371: D13596.id.diff
Fri, May 17, 4:54 PM
F13204944: D13596.diff
Wed, May 15, 1:16 AM
F13188228: D13596.diff
Sat, May 11, 5:06 AM
Unknown Object (File)
Tue, May 7, 8:39 AM
Unknown Object (File)
Fri, May 3, 8:15 AM
Unknown Object (File)
Fri, Apr 26, 3:10 AM
Unknown Object (File)
Fri, Apr 26, 3:09 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU361c81c2960e: Don't include debugging symbols in XHPAST by default
Summary

I'm not C/C++ expert, but it seems odd to me that we include debugging symbols on a normal xhpast build... doesn't this have some performance overhead?

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsupport/xhpast/Makefile:24TXT2Tab Literal
Unit
No Test Coverage
Build Status
Buildable 7202
Build 7448: [Placeholder Plan] Wait for 30 Seconds
Build 7447: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32854.Jul 8 2015, 7:31 AM
joshuaspence retitled this revision from to Don't include debugging symbols in XHPAST by default.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2015, 7:31 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence added a comment.Jul 8 2015, 7:37 AM

Running a simple script to investigate the impact of this change:

#!/bin/bash

rm -f src/.phutil_module_cache
./scripts/build_xhpast.php
time ./scripts/phutil_rebuild_map.php src
Before
real	0m26.442s
user	1m1.528s
sys	0m10.568s
After
real	0m21.172s
user	0m59.420s
sys	0m9.676s
epriestley accepted this revision.Jul 8 2015, 7:38 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2015, 7:38 AM
Closed by commit rPHU361c81c2960e: Don't include debugging symbols in XHPAST by default (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 8 2015, 8:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
support/
xhpast/
2 lines

Diff 32854

View Options

support/xhpast/Makefile

Loading...
Phabricator · Built by Phacility